Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detecting service calls that use old-style service_template #617

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

frenck
Copy link
Owner

@frenck frenck commented Feb 12, 2024

Description

Back in the Home Assistant days, services could be called in different ways. Using the service key and using the service_template key. The latter supported templates, the first didn't in the past (but now does).

service_template isn't used anymore (but Home Assistant is still backwards compatible).

This PR makes sure Spook has the same backward-compatibility.

Motivation and Context

fixes #615

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Feb 12, 2024
@frenck frenck merged commit 806a7a9 into main Feb 12, 2024
14 of 15 checks passed
@frenck frenck deleted the frenck-2024-0220 branch February 12, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
1 participant