Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate repair issue cleanup code #603

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Deduplicate repair issue cleanup code #603

merged 1 commit into from
Feb 10, 2024

Conversation

frenck
Copy link
Owner

@frenck frenck commented Feb 10, 2024

Description

SSIA

Refactor of the repair issue handling, so Spook is now handling the cleanup of them in the abstract instead of each repair individually.

Motivation and Context

uh... well.. less is more?

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@frenck frenck added the refactor Improvement of existing code, not introducing new features. label Feb 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
15.5% Duplication on New Code

See analysis details on SonarCloud

@frenck frenck merged commit 47bdf69 into main Feb 10, 2024
15 checks passed
@frenck frenck deleted the frenck-2024-0217 branch February 10, 2024 20:27
@frenck frenck mentioned this pull request Feb 15, 2024
Closed
@frenck frenck mentioned this pull request Mar 22, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Improvement of existing code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frenck