Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit use of device name in Repairs event #322

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

frenck
Copy link
Owner

@frenck frenck commented Aug 15, 2023

Description

Fixes

Entity event.repair (<class 'custom_components.spook.ectoplasms.repairs.event.RepairsSpookEventEntity'>) is implicitly using device name by not setting its name. Instead, the name should be set to None, please report it to the custom integration author.

Motivation and Context

fixes #312

How has this been tested?

Run, confirmed it is gone.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Aug 15, 2023
@frenck frenck merged commit eec4901 into main Aug 15, 2023
15 checks passed
@frenck frenck deleted the frenck-2023-1156 branch August 15, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repairs name should be set to None
1 participant