Use aiozoneinfo to avoid blocking io inside ZoneInfo #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
requested changes
Nov 15, 2024
pyproject.toml
Outdated
| @@ -28,6 +28,7 @@ version = "0.0.0" | |||
| aiohttp = ">=3.0.0" | |||
| python = "^3.11" | |||
| yarl = ">=1.6.0" | |||
| aiozoneinfo = "^0.2.1" | |||
There was a problem hiding this comment.
Instead of adding a dependency, we can also move this one out of the function scope and put it e.g., into a constant. The timezone isn't dynamic.
../Frenck
There was a problem hiding this comment.
I've updated the PR to instantiate a ZoneInfo on construct instead, is that how you would prefer it?
There was a problem hiding this comment.
That still makes it a class member.
Instead, it can be just defined as a constant at the top of the file and use the constant later on.
There was a problem hiding this comment.
Ah oh, sorry i misunderstood, i don't write python usually, so didn't know the Usual style rules,
I've made it into a const now
frenck
added
the
bugfix
wslaghekke
force-pushed
the
aiozoneinfo
branch
from
74bcda6
to
dd38109
Compare
frenck
approved these changes
Nov 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The current version throws a warning when used inside Home Assistant because of blocking calls to listdir, that happens inside the call to ZoneInfo, use
aiozoneinfoto avoid blockingRelated Issues