UI: Show warning before deploying over a lock #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user wants to deploy an app that has a lock, or if the user wants to deploy to an environment that has a lock, we now show a warning, because generally locks should not be ignored. The dialog shows which locks are the "offenders". The user can still choose to ignore this, but now they have been warned.
sven-urbanski-freiheit-com
force-pushed
the
su-warn-lock
branch
from
ab5c717 to
26700b7
Compare
sven-urbanski-freiheit-com
changed the title
services/frontend-service/src/ui/components/SideBar/SideBar.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/components/ReleaseDialog/ReleaseDialog.tsx
Outdated
Show resolved
Hide resolved
hannesg
approved these changes
Sep 22, 2023
services/frontend-service/src/ui/components/EnvironmentLockDisplay/EnvironmentLockDisplay.tsx
Outdated
Show resolved
Hide resolved
leandro-freiheit
approved these changes
Sep 22, 2023
sven-urbanski-freiheit-com
force-pushed
the
su-warn-lock
branch
from
9786a98 to
8d1ba94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user wants to deploy an app that has a lock, or if the user wants to deploy to an environment that has a lock, we now show a warning (when submitting the actions), because generally locks should not be ignored.
The dialog shows which locks are the "offenders".
The user can still choose to ignore this, but now they have been warned.
New Dialog with offending locks:
New Dialog without offending locks:
