Add networking timeouts to git pushes #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution take is highly unelegant but kinda unavoidable given the options available. Basically, libgit as most c based libs doesn't allow cancelling anything. The only thing we can do is to run the push operation in a seperate go routine and return our own timeout after some time while throwing a cancellation at the lib to stop. This is now done in the
useRemote
function. The network timeout is now 1 minute which is probably good enough for most consumers.