Fix encoding issue with http header. #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
force-pushed
the
su-header-encoding
branch
from
90136ce to
8c2b9ad
Compare
hannesg
approved these changes
Aug 28, 2023
sven-urbanski-freiheit-com
force-pushed
the
su-header-encoding
branch
from
8c2b9ad to
f40e83b
Compare
sven-urbanski-freiheit-com
added a commit
that referenced
this pull request
Aug 28, 2023
This solves #893. The issue is now handled by proper base64 encoding the headers for email and username. This mostly reverts #889, except for the improved logging. Co-authored-by: Sven Urbanski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #893.
The issue is now handled by proper base64 encoding (which is surprisingly difficult in javascript).
This mostly reverts #889, except for the improved logging.