Fix broken link in small environmentGroupChip #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
services/frontend-service/src/ui/components/chip/EnvironmentGroupChip.tsx
Outdated
Show resolved
Hide resolved
We should not render a link in the small environmentChip, because it is way too small. It also had not-so-nice css, so we just render text, as before.
sven-urbanski-freiheit-com
force-pushed
the
su-env-link-style
branch
from
9134184 to
6034b95
Compare
leandro-freiheit
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not render a link in the small environmentGroupChip, because it is way too small. It also had not-so-nice css.
It was never intended to work for environmentGroups - just environments.
Now we just render text, as before.