Block Users without Permission from Creating Environment Locks #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesg
reviewed
Jul 25, 2023
hannesg
reviewed
Jul 26, 2023
There was a problem hiding this comment.
I need to rethink this testing approach a bit. Maybe it's easier to not pass this reader around but instead have an undocumented flag on the auth package that enables mocking? At least, we definitely don't need to pass this reader around twice. The interceptor should put the verified user in the context and then it shouldn't matter how it got there.
We don't do that anymore. |
hannesg
approved these changes
Jul 27, 2023
sven-urbanski-freiheit-com
approved these changes
Jul 27, 2023
gsandok
force-pushed
the
gs/DSN-5IUHBN/add_permissions_createEnvironmentLock
branch
from
b4d6076 to
828db3a
Compare
gsandok
force-pushed
the
gs/DSN-5IUHBN/add_permissions_createEnvironmentLock
branch
from
828db3a to
094f7fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the extracted role information from the GRPC context.
When Dex is enabled then checks if associated role has permissions for createEnvironmentLock.
Blocks user if their role does not have permissions.