-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render warnings for unusual deployment situations #731
Conversation
ada3f27
to
d93cd01
Compare
We now render 2 warnings: If "prod" is ahead of "staging", that is unusual. Probably someone deployed a bugfix on prod, but forgot to lock staging. Second warning: if one env has no version deployed but the downstream of it has one. This means the next release train would get rid of it.
d93cd01
to
4b2486e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think logging this on frontend requests is not a good idea. This will spam our logs with warnings when a user views the page and will be silent when nobody is looking. I would either do this as a frontend-only feature and if you want to write a log then log this when the problem is created instead of when it's viewed.
@hannesg which line are you referring to? I could just remove that - reworking this to calculate the warnings on frontend-only would be a huge change though (And I'm not sure if that's the right direction to go in).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try!
We now render 2 warnings:
If "prod" is ahead of "staging", that is unusual. Probably someone deployed a bugfix on prod, but forgot to lock staging.
If one env has no version deployed but the downstream of it has one. This means the next release train would get rid of it.
SRX-S3C8AL