Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render warnings for unusual deployment situations #731

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

sven-urbanski-freiheit-com
Copy link
Contributor

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com commented Jun 16, 2023

We now render 2 warnings:

  1. If "prod" is ahead of "staging", that is unusual. Probably someone deployed a bugfix on prod, but forgot to lock staging.
    Screenshot from 2023-06-16 17-04-08

  2. If one env has no version deployed but the downstream of it has one. This means the next release train would get rid of it.
    Screenshot from 2023-06-16 17-03-13

SRX-S3C8AL

We now render 2 warnings: If "prod" is ahead of "staging", that is unusual.
Probably someone deployed a bugfix on prod, but forgot to lock staging.

Second warning: if one env has no version deployed but the downstream of it has one.
This means the next release train would get rid of it.
Copy link
Member

@hannesg hannesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think logging this on frontend requests is not a good idea. This will spam our logs with warnings when a user views the page and will be silent when nobody is looking. I would either do this as a frontend-only feature and if you want to write a log then log this when the problem is created instead of when it's viewed.

@sven-urbanski-freiheit-com
Copy link
Contributor Author

I think logging this on frontend requests is not a good idea. This will spam our logs with warnings when a user views the page and will be silent when nobody is looking. I would either do this as a frontend-only feature and if you want to write a log then log this when the problem is created instead of when it's viewed.

@hannesg which line are you referring to?
I guess this one? https://github.com/freiheit-com/kuberpult/pull/731/files#diff-127dcd8e4f149221e75212d5fb9fed3b0184531ffe4f41952d75d8e787659658R244

I could just remove that - reworking this to calculate the warnings on frontend-only would be a huge change though (And I'm not sure if that's the right direction to go in).

write a log then log this when the problem is created instead of when it's viewed.
It's already logged on startup.

@hannesg hannesg self-requested a review June 19, 2023 09:03
Copy link
Member

@hannesg hannesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com enabled auto-merge (squash) June 19, 2023 15:18
@sven-urbanski-freiheit-com sven-urbanski-freiheit-com deleted the su-warnings branch June 19, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants