-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move lock message inputs from inline to actions cart #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdcds
reviewed
Apr 26, 2022
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.test.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
Becuase of a problem on runtime in typescript the enum was undefined. therfore extracting it into a new file would solve the problem
tameremad
requested review from
fdcds,
sven-urbanski-freiheit-com and
medo-freiheit
April 29, 2022 18:50
hannesg
reviewed
May 5, 2022
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
fdcds
reviewed
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments.
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
services/frontend-service/src/ui/ActionsCart/CheckoutDialog.tsx
Outdated
Show resolved
Hide resolved
sven-urbanski-freiheit-com
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to make locking an application or environment simpler. Most use cases include adding multiple locks at the same time (with the same message). So by moving the input field to the cart, the locking process is simpler for the users.
The
BatchAction
type is generated from the API proto file directly. This type includes acreate...(env/app)...Lock
. which was used to represent lock actions in the Cart.After moving the input field, the lock button has to add lock actions to Cart without any lock message. which creates a problem because the message field is required for
BatchAction
but it's not yet available.To solve it, This PR will:
CartAction
, and then use it to represent different actions in the frontend.ReleaseDialog/LockButtonGroup
and fromReleaseDialog/CreateLockButton
CartAction
instead ofBatchAction
inWarnings
,Releases
,ReleaseDialog
,ActionsCart
, andindex.tsx
.ActionDetails
that contains theCartAction
type, and the function to transformCartActions
toBatchActions
before sending the API request.getActionDetails
,ActionTypes
fromConfirmationDialog
toActionDetails
CheckoutDialog
that appears only when the cart contains create-lock actions. use this input as the lock message.ActionDetails.test
and modify the tests ofCheckoutDialog.test
andConfirmationDialog.test
to useCartAction