gluon-core: lua: wireless: use libiwinfo-lua for find_phy() #3223
Conversation
find_phy() did not match OpenWrt's logic for PHY names anymore, and could not handle PHYs that don't match the 'phyX' naming scheme. Instead of trying to add more complex logic to our own code, simply do what OpenWrt does and use iwinfo to resolve UCI sections to PHY names.
|
I just tested the fix by manually editing the patch into the lua on a Ubiquiti UniFi 6 LR v3 - which has a working status page now. |
|
Tested on Xiaomi AX3200, works flawlessly! |
|
Thanks for testing. By the way, does the PHY renaming only happen when the WiFi is enabled, or also in Config Mode? If would be good to have some more tests of the affected code paths:
|
|
|
|
@kpanic23 are you able to do the additional tests, too? would be great :) |
|
in-case anyone needs a build: |
freifunk-gluon/gluon#3223 also fix issue building threetime-reboot package
|
|
|
@kpanic23 Please also check the things I asked in a comment above:
|
@neocturne i tested this on a Xiaomi AX3200 with the ffac images provided by @Djfe . results: any other test or info needed for this PR? |
|
Thanks! Everything looking as I expected, so this should be ready. A bit confusing that PHY names are different between config mode and regular operation (because renaming happens when the WiFi is started), but that is on OpenWrt, and AFAIK we don't display the PHY names anywhere in the config UI or status page. |
|
Successfully created backport PR for |
|
Git push to origin failed for v2023.2.x with exitcode 1 |
find_phy() did not match OpenWrt's logic for PHY names anymore, and could not handle PHYs that don't match the 'phyX' naming scheme. Instead of trying to add more complex logic to our own code, simply do what OpenWrt does and use iwinfo to resolve UCI sections to PHY names.
Supersedes #3155
Closes #3020
Draft: This is entirely untested. Will test on an FB4040 tomorrow - would be great to get a test on a device with wifiX PHY names as well.
There is some subsequent cleanup possible by passing around only UCI section names instead of the whole section table (which may not even need to be queried at all in some cases), but that will happen as a separate PR, so this one can be backported to 2023.2.x.