Broaden runAt types to facilitate injection from the manifest

fregante · Mar 9, 2023 · b8f88a2 · b8f88a2
1 parent 127038f
commit b8f88a2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 18 deletions.
diff --git a/global.d.ts b/global.d.ts
diff --git a/index.ts b/index.ts
@@ -243,7 +243,7 @@ async function injectContentScriptInSpecificTarget(
 			allFrames,
 			files: script.css ?? [],
 			matchAboutBlank: script.matchAboutBlank ?? script.match_about_blank,
-			runAt: script.runAt ?? script.run_at,
+			runAt: script.runAt ?? script.run_at as RunAt,
 		}, options),
 
 		executeScript({
@@ -252,7 +252,7 @@ async function injectContentScriptInSpecificTarget(
 			allFrames,
 			files: script.js ?? [],
 			matchAboutBlank: script.matchAboutBlank ?? script.match_about_blank,
-			runAt: script.runAt ?? script.run_at,
+			runAt: script.runAt ?? script.run_at as RunAt,
 		}, options),
 	]);
 

diff --git a/package.json b/package.json
@@ -48,11 +48,11 @@
 	},
 	"devDependencies": {
 		"@sindresorhus/tsconfig": "^3.0.1",
-		"@types/chrome": "^0.0.210",
+		"@types/chrome": "^0.0.220",
 		"@types/jest": "^29.4.0",
 		"jest-chrome": "^0.8.0",
-		"typescript": "^4.9.4",
-		"vitest": "^0.28.3",
+		"typescript": "^4.9.5",
+		"vitest": "^0.29.2",
 		"xo": "^0.53.1"
 	}
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -4,7 +4,6 @@
 		"outDir": "."
 	},
 	"files": [
-		"global.d.ts",
 		"types.d.ts",
 		"index.test.ts",
 		"index.ts"

diff --git a/types.d.ts b/types.d.ts
@@ -18,7 +18,7 @@ export interface ContentScript {
 	js?: string[] | ExtensionFileOrCode[];
 
 	/**
-	 * Prefer `allFrames`
+	 * @deprecated Prefer `allFrames`
 	 */
 	all_frames?: boolean;
 
@@ -29,7 +29,7 @@ export interface ContentScript {
 	allFrames?: boolean;
 
 	/**
-	 * Prefer `matchAboutBlank`
+	 * @deprecated Prefer `matchAboutBlank`
 	 */
 	match_about_blank?: boolean;
 
@@ -40,9 +40,9 @@ export interface ContentScript {
 	matchAboutBlank?: boolean;
 
 	/**
-	 * Prefer `runAt`
+	 * @deprecated Prefer `runAt`
 	 */
-	run_at?: RunAt;
+	run_at?: string;
 
 	/**
 	 * The soonest that the JavaScript or CSS will be injected into the tab. Defaults to "document_idle".