[PFG-3342] fix: normalize promise now have the ability to treat errors properly #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericlarsonfreestar
approved these changes
Sep 5, 2024
yagovelazquezfreestar
force-pushed
the
PFG-3342-clone-console-errors-on-refresh
branch
from
13cdca8 to
6a8cfc1
Compare
yagovelazquezfreestar
force-pushed
the
PFG-3342-clone-console-errors-on-refresh
branch
from
6a8cfc1 to
ab84d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The normalizePromise is throwing uncaught errors in console and this have been an issue for a publisher. This PR goal is to only handle the promise error since it is a good pratice to do so. Also, for this function is normal to sometimes it to throw. We want though to investigate a little bit more, this is mean't to be only a hotfix. It's still possible to see the error by adding to the url pbjs_debug=true.
PFG-3342