Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 2.4 and ruby-head in .travis.yml #297

Merged

Conversation

junaruga
Copy link
Contributor

I want to add ruby-2.4 and ruby-head in .travis.yml.

Ruby 2.4

I added "2.4.0", not "2.4".
Because last month I tried "2.4" in .travis.yml, it was not available.
I can not find official document for that.

ruby-head

I want to add ruby-head as allow_failures in .travis.yml.
I think this is useful.
Because we can prepare before next version Ruby 2.5 release.
Though it might not be useful until the actual preview release.
We can support the next version as faster.

We can see this kind of logic in rails, rspec and cucumber and etc.
I think that is the reason why rails and rspec can support new version Ruby as faster.

https://github.com/rails/rails/blob/master/.travis.yml
https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml
https://github.com/sparklemotion/nokogiri/blob/master/.travis.yml

Is it possible to add it?

Thanks.

@floehopper floehopper self-assigned this Mar 22, 2017
@floehopper
Copy link
Member

Thanks. I'd be happy to accept this PR if you split it up into multiple commits as follows:

  1. Convert all existing MAJOR.MINOR Ruby versions to latest MAJOR.MINOR.PATCH as suggested in rvm: 2.4 installation fails travis-ci/travis-ci#7077. Please reference this issue in the commit message.
  2. Additions for Ruby v2.4.0 - it needs to be added here, here, and here. Your PR missed the third of these, i.e. the one for Test::Unit.
  3. Additions for ruby-head. I think this should be added in the same way, i.e. in 3 places - or at least for both Minitest and Test::Unit. Also explain why you've added allow_failures and fast_finish options in the commit note.

@junaruga
Copy link
Contributor Author

@floehopper hi, ok let me try it. I missed test-unit case.

@junaruga junaruga force-pushed the feature/travis-add-ruby24-and-ruby-head branch from 1ccb2d3 to 7f9be45 Compare March 22, 2017 16:17
* allow_failures is because it's good to know new version Ruby's issue
  as faster before the release.
* fast_finish is to get the Travis result as faster
  without waiting the result of the "allow_failures" items.
  See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
@junaruga junaruga force-pushed the feature/travis-add-ruby24-and-ruby-head branch from 295deb7 to 1aee6c9 Compare March 22, 2017 16:22
@floehopper
Copy link
Member

@junaruga: Thanks. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants