Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(favorites): frontend revisions to pray and pay project #4580

Open
wants to merge 64 commits into
base: main
Choose a base branch
from

Conversation

v-anne
Copy link
Contributor

@v-anne v-anne commented Oct 16, 2024

This is the PR for making frontend changes to the pray and pay user interface.

Mike had some great comments in #4507, so we'll start with them and see what's needed once the low-hanging fruit is done.

Additions include:

  • Allowing users to request a document from the recap_document.html page.
  • Revamping UI of top_prayers.html to provide better UX.
  • Creating user_prayers.html page to allow users to see their open and fulfilled prayers, and also summary statistics about how many requests they've had fulfilled. In a future PR, this will be made similar to tags to allow people (e.g., freelance journalists) to share documents they've requested.
  • documentation for how pray and pay project works.
  • minor grammar changes to email notifications.

@v-anne
Copy link
Contributor Author

v-anne commented Oct 16, 2024

@ERosendo this is the PR I'm going to build off of.

@mlissner
Copy link
Member

mlissner commented Oct 16, 2024

Seeing some commit messages around the user-prayer page. Reminds me that it doesn't have to be available in the profile section, just like tags aren't. The user prayers page could just be linked from the mouseover for each emoji or from the most-wanted page, for example.

@v-anne
Copy link
Contributor Author

v-anne commented Oct 16, 2024

Yeah, tags are what I am aiming to emulate.

@v-anne
Copy link
Contributor Author

v-anne commented Oct 16, 2024

image I'm having some issues getting the three buttons to display inline with each other in `recap_document.html`. Ideally, the prayer button would be to the right of the other two.

@v-anne
Copy link
Contributor Author

v-anne commented Oct 16, 2024

image

Having same issue with the button on the modal. There's also a related issue where if I click the prayer button repeatedly, the count will increase despite having exhausted the quota.

I gather this is an issue with the CSS, but I tried making some changes and was unsuccessful.

@mlissner
Copy link
Member

@ERosendo, do you think you could help, please?

@ERosendo
Copy link
Contributor

@mlissner sure! 👍

@v-anne
Copy link
Contributor Author

v-anne commented Oct 17, 2024

@ERosendo in addition to those two issues with the buttons, I've mostly finished a MVP of the user_prayers.html page.

This is what it currently looks like. The status column is broken; I can't figure out why the backend isn't passing the information through to the template. I intend to add a button to allow users to delete requests and one for them to download available documents as well.

image

pre-commit-ci bot and others added 24 commits October 21, 2024 20:04
@mlissner
Copy link
Member

@v-anne, I noticed this PR is paused. Are you waiting for feedback or something else?

@v-anne
Copy link
Contributor Author

v-anne commented Nov 13, 2024

Sorry @mlissner, I had stepped back because I thought @ERosendo was going to take a look at some of the issues I had raised with my code.

@mlissner
Copy link
Member

Got it. We're moving to a sprint/scrum model, but I'll get this on his new list. :)

@v-anne

This comment was marked as off-topic.

@mlissner

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

Successfully merging this pull request may close these issues.

3 participants