Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): remove OpenAPI/Swagger integration #3770

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

cweider
Copy link
Collaborator

@cweider cweider commented Feb 13, 2024

The django-rest-framework's built-in support for OpenAPI schema generation has been deprecated (encode/django-rest-framework#8773). drf-spectacular is the recommended alternative, but CourtListener's schema has always been experimental. Moreover the current integration is crashing and has other bugs that prevent its effective use. Outright removal, rather than replacement is the best way forward.

Fixes: #3653, #1616

The `django-rest-framework`'s built-in support for OpenAPI schema
generation has been deprecated (encode/django-rest-framework#8773).
`drf-spectacular` is the recommended alternative, but CourtListener's
schema has always been experimental. Moreover the current integration
is crashing and has other bugs that prevent its effective use.
Outright removal, rather than replacement is the best way forward.

Fixes: freelawproject#3653, freelawproject#1616
@cweider cweider requested a review from mlissner February 13, 2024 22:11
@cweider
Copy link
Collaborator Author

cweider commented Feb 13, 2024

As-is change doesn’t mention removal in the REST API change log (or affect version), but it could:

<h1 id="about">REST API Change Log</h1>

@mlissner mlissner enabled auto-merge February 13, 2024 22:56
@mlissner
Copy link
Member

Thanks Chad. Good to have this cleaned up. Setting for auto-merge!

@mlissner mlissner merged commit 0b82948 into freelawproject:main Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Swagger completely
2 participants