Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from WSGI to ASGI #2783

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Migrate from WSGI to ASGI #2783

merged 1 commit into from
Jun 2, 2023

Conversation

ttys0dev
Copy link
Contributor

Minimal version of #2720.

@ttys0dev ttys0dev mentioned this pull request May 26, 2023
Merged
@ttys0dev
Copy link
Contributor Author

ttys0dev commented Jun 1, 2023

rebased

mlissner
mlissner reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK. Can you say you tested it to make sure it's all wired up properly? I'd rather not deploy a change like this without some level of testing.

cl/asgi.py Outdated Show resolved Hide resolved
@ttys0dev
Copy link
Contributor Author

ttys0dev commented Jun 1, 2023

Can you say you tested it to make sure it's all wired up properly? I'd rather not deploy a change like this without some level of testing.

I tested with the production gunicorn/uvicorn image locally and didn't notice any regressions.

@ttys0dev
Copy link
Contributor Author

ttys0dev commented Jun 1, 2023

rebased

ttys0dev
ttys0dev commented Jun 2, 2023
View reviewed changes
docker/django/Dockerfile Outdated Show resolved Hide resolved
@mlissner mlissner merged commit cf5f05f into freelawproject:main Jun 2, 2023
@ttys0dev ttys0dev deleted the minimal-asgi branch June 2, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlissner mlissner mlissner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttys0dev @mlissner