Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to gthread workers to prevent upload timeouts with sync workers #2585

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

ttys0dev
Copy link
Contributor

Using gthread workers should prevent uploads from timing out at 3 minutes.

See docs:
https://docs.gunicorn.org/en/stable/settings.html#timeout

@mlissner
Copy link
Member

This one is a month old and we haven't gotten more than one person asking for it in all this time. I also haven't been shown how this change fixes the problem or what the pros/cons of it are. Therefore, I'm closing it, though I appreciate the energy you put in. I think it's defacto closed already since it's stalled for a month, but if others are also feeling the pain of this issue, please chime in.

@mlissner mlissner closed this Apr 11, 2023
@ttys0dev
Copy link
Contributor Author

This one is a month old and we haven't gotten more than one person asking for it in all this time.

Can confirm that the problem is still present, although in practice it's hit fairly rarely. The reproduction steps are trivial so I don't see why more bug reports would be helpful here to confirm an already confirmed reproducable bug.

I also haven't been shown how this change fixes the problem or what the pros/cons of it are.

Either way sync workers are generally a bad idea when dealing with file uploads like this unless you put a reverse caching proxy like nginx in front(I assume there is not one right?). I think in general it's a bad idea to not have a caching reverse proxy in front. See details https://dev.to/lsena/gunicorn-worker-types-how-to-choose-the-right-one-4n2c.

I think it's defacto closed already since it's stalled for a month, but if others are also feeling the pain of this issue, please chime in.

Not sure why it stalled, are the reproduction steps not working? The bug is really obvious once you look at the timings on file uploads in the extension debugger and see that they always fail at 3 minutes exactly.

Using gthread workers should prevent uploads from timing out at 3 minutes.

See docs:
https://docs.gunicorn.org/en/stable/settings.html#timeout
@mlissner mlissner merged commit 1903f17 into freelawproject:main Apr 18, 2023
@ttys0dev ttys0dev deleted the gthread branch April 18, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants