Convert DBus objects into native python objects #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcritten
force-pushed
the
issue_305
branch
2 times, most recently
from
5857378
to
4d7dba6
Compare
flo-renaud
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Hi @rcritten
thanks for the PR. Please find inline comments.
There were cases where values were taken directly from DBus objects. This worked in some cases but not in the case of the token name. Fixes: freeipa#305 Signed-off-by: Rob Crittenden <[email protected]>
Ubuntu has pylint 3.0.1 which is apparently incompatible with pylint_plugins.py. Disable this temporarily. Chances are good that once this is addressed in freeipa it can be ported back here as well. Signed-off-by: Rob Crittenden <[email protected]>
flo-renaud
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were cases where values were taken directly from DBus objects. This worked in some cases but not in the case of the token name.
Fixes: #305