Use the subject base from the IPA configuration, not REALM #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected certificates were hardcoded with O={REALM} which
would return false-positives if the customer defined their
own certificate subject base.
Also add a search filter to only retrieve the certificate(s) we
want to examine rather than the entire contents.
Fixes: freeipa#253
Signed-off-by: Rob Crittenden <[email protected]>
Notice this while ensuring I didn't have any leftovers during development. Related: freeipa#253 Signed-off-by: Rob Crittenden <[email protected]>
flo-renaud
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
@rcritten thanks for the patch, LGTM. Tested on an ipa server installed with --ca-subject "CN=Custom CA Authority,O=Other" --subject-base "O=MySubjectBase":
- without the patch, ipa-healthcheck returns 4 errors while it should not (ocspSigningCert cert-pki-ca, subsystemCert cert-pki-ca, auditSigningCert cert-pki-ca and Server-Cert cert-pki-ca)
- with the patch, ipa-healthcheck returns 0 error.
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the subject base from the IPA configuration, not REALM
The expected certificates were hardcoded with O={REALM} which
would return false-positives if the customer defined their
own certificate subject base.
Also add a search filter to only retrieve the certificate(s) we
want to examine rather than the entire contents.
Fixes: #253
Signed-off-by: Rob Crittenden [email protected]