This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
Remove all traces of pledge feature in the codebase #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Let's consider this once #143 is in; would be nice to no longer advertise the "pledge" feature when we blog about the leaderboards feature, since we never implemented a workflow for managing pledges nor do we intend to. |
SaptakS
force-pushed
the
delete-pledge-feature
branch
from
f6b2093 to
b265116
Compare
SaptakS
force-pushed
the
delete-pledge-feature
branch
2 times, most recently
from
3a2c657 to
5a70cbe
Compare
|
Rebased and fixed the conflicts. Looks all good to me. I think it would be nice to do |
harrislapiroff
force-pushed
the
delete-pledge-feature
branch
from
5a70cbe to
ef28f27
Compare
harrislapiroff
approved these changes
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #162
Performed the following tests locally:
This does not add a migration, since the entire
pledgesapp is removed via this PR. One way to remove its traces from the database is viamanage.py pledges zerobefore applying this PR.