Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translation requirements are production requirements #6996

Merged
merged 1 commit into from
Oct 12, 2023
Merged

docs: translation requirements are production requirements #6996

merged 1 commit into from
Oct 12, 2023

Conversation

cfm
Copy link
Member

@cfm cfm commented Oct 12, 2023

Status

Ready for review

Description of Changes

Seeks to prevent oversights like #6954 (comment) by adding translation.in to the list of production requirements files.

Testing

  • Visual review.

Deployment

Workflow only; no deployment considerations.

@cfm cfm requested a review from a team as a code owner October 12, 2023 19:48
@cfm cfm mentioned this pull request Oct 12, 2023
Merged
41 tasks
legoktm
legoktm approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is something that I should've done as part of 6606fe2.

@legoktm legoktm merged commit f01decb into develop Oct 12, 2023
@legoktm legoktm deleted the trans-deps-are-prod-deps branch October 12, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legoktm legoktm legoktm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfm @legoktm