Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump 2.6.0 rc2 version #6863

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Bump 2.6.0 rc2 version #6863

merged 1 commit into from
Jun 20, 2023

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Towards #6798

  • bumps version to 2.6.0~rc2

Testing

  • CI is passing
  • version bumped successfully
  • changelog changes look reasonable

@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner June 20, 2023 19:52
@legoktm legoktm changed the base branch from develop to release/2.6.0 June 20, 2023 19:57
@legoktm
Copy link
Member

legoktm commented Jun 20, 2023

We probably also want the changelog entry for #6847 (a354afa)

@zenmonkeykstop
Copy link
Contributor Author

zenmonkeykstop commented Jun 20, 2023 •
edited
Loading

We probably also want the changelog entry for #6847 (a354afa)

Explicitly left out coz it's a fix for an unreleased feature, so users would never have encountered it.

buttt by that logic listing the pr in the feature entry makes sense.

@zenmonkeykstop zenmonkeykstop force-pushed the bump-2.6.0-rc2-version branch from 30c5c5e to 50de1c9 Compare June 20, 2023 20:34
legoktm
legoktm approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI passing

@zenmonkeykstop zenmonkeykstop merged commit 9db047f into release/2.6.0 Jun 20, 2023
@legoktm legoktm deleted the bump-2.6.0-rc2-version branch June 20, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legoktm legoktm legoktm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenmonkeykstop @legoktm