Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed CRYPTOGRAPHY_ALLOW_OPENSSL_102 environment variable #6606

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

lsd-cat
Copy link
Member

@lsd-cat lsd-cat commented Oct 8, 2022

SecureDrop has dropped support of Xenial in #5725

As described in the cryptography documentation, the CRYPTOGRAPHY_ALLOW_OPENSSL_102 was used to force compatibility between cryptography==3.2 and OpenSSL 1.0.2.
The current version of OpenSSL in Focal is in the 1.1 branch and also cryptography is now pinned to the cryptography>=3.4.7 version.

The description of the original compatibility issue is here https://cryptography.io/en/3.2/faq/
The commit of the original change is here 4569657

Status

Ready for review

Description of Changes

Dropping the flag should have no effect on any supported system.

Testing

A normal test run in staging and prod, if any function that uses the cryptography module works, then everything should be working as usual.

Checklist

My staging environment is currently undergoing other disruptive testing and thus I have not run the infra tests yet.

@lsd-cat lsd-cat requested a review from a team as a code owner October 8, 2022 17:18
@legoktm legoktm self-assigned this Oct 11, 2022
@zenmonkeykstop zenmonkeykstop self-assigned this Oct 25, 2022
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in staging, no issues with any crypto-related functionality. LGTM

@zenmonkeykstop zenmonkeykstop merged commit 553b7fe into freedomofpress:develop Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants