Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor source functional tests codenames and collision #6361

Conversation

nabla-c0d3
Copy link
Contributor

@nabla-c0d3 nabla-c0d3 commented Mar 26, 2022

Status

Work in progress

Description of Changes

This PR continue the work started in #6307, by bringing the new test code and fixtures to a few more functional tests for the source app.

As before, the goals are to:

  • Split the FunctionalTest and the related MixIn classes into smaller classes in order to make the tests more readable.
  • Use more modern fixtures that don't rely on mutating the SDConfig object or attributes attached to the Test c;lass.
  • Overall, speed up and simplify the functional tests. After this work is done (more PRs to come), it should also be possible to run the functional tests in parallel, to make them even faster.

@nabla-c0d3 nabla-c0d3 force-pushed the refactor-source-functional-tests-codenames-and-collision branch 2 times, most recently from 3702227 to a792280 Compare March 28, 2022 20:15


class TestSourceInterfaceDesignationCollision(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was moved to a separate file below in the PR.

@nabla-c0d3 nabla-c0d3 force-pushed the refactor-source-functional-tests-codenames-and-collision branch from a792280 to 696a3f8 Compare March 29, 2022 20:08
@nabla-c0d3 nabla-c0d3 marked this pull request as ready for review March 29, 2022 20:33
@nabla-c0d3 nabla-c0d3 requested a review from a team as a code owner March 29, 2022 20:33
@nabla-c0d3 nabla-c0d3 marked this pull request as draft March 29, 2022 20:35
@nabla-c0d3 nabla-c0d3 force-pushed the refactor-source-functional-tests-codenames-and-collision branch from 696a3f8 to c5844cb Compare March 29, 2022 20:46
@nabla-c0d3 nabla-c0d3 marked this pull request as ready for review March 29, 2022 21:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #6361 (c5844cb) into develop (1cc675f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6361   +/-   ##
========================================
  Coverage    83.98%   83.98%           
========================================
  Files           61       61           
  Lines         4301     4301           
  Branches       522      522           
========================================
  Hits          3612     3612           
  Misses         565      565           
  Partials       124      124           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nabla-c0d3 nabla-c0d3 force-pushed the refactor-source-functional-tests-codenames-and-collision branch from c5844cb to c187124 Compare April 4, 2022 19:28
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@legoktm legoktm merged commit f0dd9a8 into freedomofpress:develop Apr 13, 2022
@nabla-c0d3
Copy link
Contributor Author

The next PR is ready: #6365

@nabla-c0d3 nabla-c0d3 deleted the refactor-source-functional-tests-codenames-and-collision branch June 11, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants