Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring security level instructions up to date #6320

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Bring security level instructions up to date #6320

merged 1 commit into from
Mar 8, 2022

Conversation

eaon
Copy link
Contributor

@eaon eaon commented Mar 7, 2022

Status

Ready for review

Description of Changes

Fixes #6319. Changes Tor Browser Security Level instruction strings to be in line with current TB user interface

Testing

  • Open Tor Browser
  • Ensure the Security Level preference is set to Standard
  • Visit source index page
  • Click on the underlined Security Level link in the purple warning on the top of the page
  • Follow instructions of the dialog that opens up

Checklist

  • I have written a test plan and validated it for this PR
  • These changes do not require documentation

@eaon
Bring security level instructions up to date
92d09af 
Tor Browser changed its UI for how security levels are set, so we
instruct sources with better specificity
@eaon eaon requested a review from a team as a code owner March 7, 2022 18:42
eloquence
eloquence approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not merging as I'm not a maintainer).

legoktm
legoktm approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified test plan, LGTM.

@legoktm legoktm merged commit 680d2d0 into develop Mar 8, 2022
@legoktm legoktm deleted the 6319-update-security-level-instructions branch March 8, 2022 14:55
@zenmonkeykstop zenmonkeykstop mentioned this pull request Mar 17, 2022
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eloquence eloquence eloquence approved these changes

@legoktm legoktm legoktm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SI Tor Browser security level instructions are outdated
3 participants
@eaon @legoktm @eloquence