Backport reply key mtime/ctime update #6277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set the GPG key creation time to 2013-05-14 to hide when they were created, revealing when a source started using SecureDrop. However this information was being leaked via the file modification time of the private key material in the $keydir/private-keys-v1.d/ folder. While we can easily change a file's mtime to a past date, faking the ctime really isn't possible. So instead we touch each private key when the source app starts to mask the real creation time. Because of the nightly restarts, this will be updated within 24 hours of source creation. Fixes freedomofpress/securedrop-security#71. (cherry picked from commit bff89a3)
conorsch
approved these changes
Feb 16, 2022
Codecov Report
@@ Coverage Diff @@
## release/2.2.0 #6277 +/- ##
=================================================
- Coverage 84.09% 84.07% -0.02%
=================================================
Files 60 60
Lines 4199 4208 +9
Branches 506 508 +2
=================================================
+ Hits 3531 3538 +7
- Misses 548 549 +1
- Partials 120 121 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Backports #6270 .
Testing
release/2.2.0