adds "skip to main content" link to all pages that inherit from base templates #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
…templates In accordance with <https://webaim.org/techniques/skipnav/>, the links are visually hidden until they receive focus, to benefit users navigating by keyboard whether or not they are using a screen-reader. The Source Interface's link is looser than that on the Journalist Interface: it jumps to a MAIN element that includes some navigational content, and it doesn't appear at all on the landing page. However, the point of a skip link is to skip sections *repeated* across a Web site, and the Source Interface is small enough, and sources' interactions with it purposeful enough, that I believe this implementation meets the spirit of WCAG 2.4.1 for SecureDrop's purposes.
Codecov Report
@@ Coverage Diff @@
## develop #6237 +/- ##
========================================
Coverage 85.12% 85.12%
========================================
Files 59 59
Lines 4088 4088
Branches 487 487
========================================
Hits 3480 3480
Misses 491 491
Partials 117 117 Continue to review full report at Codecov.
|
legoktm
approved these changes
Feb 25, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Towards #5972, adds a "skip to main content link" to all pages that inherit from base templates.
Testing
maincontent.Deployment
No deployment considerations.
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development container