Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switches updater-gui-tests to cimg/python:3.7 #6069

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

cfm
Copy link
Member

@cfm cfm commented Aug 17, 2021

Status

Ready for review

Description of Changes

  1. Fixes updater-gui-tests fails on changed Debian APT metadata #6068 by moving from the older circleci/ image series, based on Debian Buster, to the newer cimg/ series, based on Ubuntu Focal.
  2. Closes Update Python version for updater-gui-tests #6025 by bumping from python:3.5 to python:3.7.

Together, these changes bring updater-gui-tests in line with other CI jobs that use CircleCI's python images rather than the base ubuntu images.

Testing

  • updater-gui-tests passes in CI.

Deployment

Development-only; no deployment considerations.

Checklist

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review
    • Since other SecureDrop projects already use both Python 3.7 in general and cimg/python:3.7, I do not believe a diff review is necessary.

@cfm
Copy link
Member Author

cfm commented Aug 17, 2021

I've taken the liberty of marking this an urgent off-sprint issue on the grounds that it's blocking CI, but please feel free to disabuse me of my fervor if mistaken. :-)

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - diff review not required as no prod deps touched.

@zenmonkeykstop zenmonkeykstop merged commit 6df6672 into develop Aug 17, 2021
@zenmonkeykstop zenmonkeykstop deleted the 6068-updater-gui-tests-base branch August 17, 2021 05:48
@conorsch conorsch mentioned this pull request Aug 17, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updater-gui-tests fails on changed Debian APT metadata Update Python version for updater-gui-tests
2 participants