uses valid BCP47/RFC5646 RequestLocaleInfo.language_tag
s in locale selectors
#6067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review, but this branch depends on and includes commits pending merge in:
Description of Changes
Closes #6056 by:
i18n.map_locale_display_names()
so that the values of the globalLOCALES
dictionary arei18n.RequestLocaleInfo
instances rather than strings; andsecuredrop/{journalist,source}_templates/locales.html
accordingly to use theRequestLocaleInfo.display_name
property in user-facing text and theRequestLocaleInfo.language_tag
property as required for thea[lang,hreflang]
attributes to validate.Testing
Follow #6056's steps to reproduce:
develop
(or, pending refactors Source Interface for semantic HTML5/ARIA markup #6041, on its branch5986-semantic-source-interface
)a[lang,hreflang]
attributes.6056-language-tag
a[lang,hreflang]
attributes.Deployment
No deployment considerations.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development container