Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restricts staging-test-with-rebase to release branches and nightlies #6063

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

cfm
Copy link
Member

@cfm cfm commented Aug 13, 2021

Status

Work in progress

Description of Changes

Towards #5336, restrict staging-test-with-rebase to run only:

  1. on pushes to release/* branches; and
  2. as part of the nightly workflow.

Testing

To test the restriction to release/* branches:

  1. Confirm that staging-test-with-rebase has not run on this branch.
  2. Test staging-test-with-rebase's filters.branches.only regex against a known release/ branch.

I'm not aware of a way to test the inclusion of staging-test-with-rebase as a job in the nightly workflow until this PR is merged into develop, but this change is trivial.

Deployment

Development-only; no deployment considerations.

Checklist

If you made non-trivial code changes:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

Per #5336, these CI changes imply process changes that will need to be determined and documented.

@cfm
Copy link
Member Author

cfm commented Aug 18, 2021

s/Closes/Towards at @conorsch's request. :-)

@cfm cfm marked this pull request as ready for review August 18, 2021 16:37
@cfm cfm requested a review from a team as a code owner August 18, 2021 16:37
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants