Updates testinfra tests to run cleanly in production from an Admin Workstation #6032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkstation: - Overrides default variables with values from production site-specific file - Generalizes nightly update/upgrade/reboot checks - Sets expected repo URL based on workstation ansible defaults
rmol
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
prod
- Provision a production system based on the latest tag (2.0.0) (VMs or HW). Set a non-standard value for the reboot time. If practical, use non-standard IPs (ie other than 10.20.2.2 and 10.20.3.2) for the app and mon servers.
- I did set a different reboot time, and used different IP addresses.
- install the testinfra dependencies with
./securedrop-admin setup -t - run the testinfra suite with
./securedrop-admin verify - verify that multiple test errors are seen relating to OSSEC, IP addresses, and update scheduling
- check out this branch on the Admin Workstation
- run testinfra again with
./securedrop-admin --force verify - verify that all tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #6022.
Testing
prod
./securedrop-admin setup -t./securedrop-admin --force verifystaging
make testinfra, and verify that tests pass.Deployment
(No deployment issues)
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made non-trivial code changes:
Choose one of the following: