Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] #5998 fix: added match for new key in updater #6001

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

kushaldas
Copy link
Contributor

Status

Ready for review

Description of Changes

Backport of #5998

Testing

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you added or removed a file deployed with the application:

  • I have updated AppArmor rules to include the change

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

@kushaldas kushaldas requested a review from a team as a code owner June 17, 2021 12:29
@codecov-commenter
Copy link

Codecov Report

Merging #6001 (59d82df) into release/2.0.0 (2011565) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/2.0.0    #6001   +/-   ##
==============================================
  Coverage          85.12%   85.12%           
==============================================
  Files                 55       55           
  Lines               3865     3865           
  Branches             480      480           
==============================================
  Hits                3290     3290           
  Misses               463      463           
  Partials             112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2011565...59d82df. Read the comment docs.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, approving.

@zenmonkeykstop zenmonkeykstop merged commit b4050a9 into release/2.0.0 Jun 17, 2021
@rmol rmol deleted the backport_5998 branch June 23, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants