-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes old release signing key from securedrop-keyring #5979
Conversation
- Removed old key from existing keyring using commands: ``` cd install_files/securedrop-keyring gpg --no-default-keyring --keyring etc/apt/trusted.gpg.d/securedrop-keyring.gpg \ --delete-key "22245C81E3BAEB4138B36061310F561200F4AD77" ``` - Updated testinfra test to verify that only new signing key is present.
We've discussed including this change for v2.0.0, but decided against it: right now, the prod Release file is still signed with the old key, so let's continue to honor that config until we've shipped v2. Then we can follow up in the n+1 release and pull in the changes presented here, as well as yanking out the dual-key logic in e.g. the Tails Workstation admin logic. |
Testing locally:
That's what we want! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's queue it up for 2.1.0.
Follow-up to #5979. Removes the old, i.e. 22245C81E3BAEB4138B36061310F561200F4AD77, apt key from the Ansible install-time logic. The key has been expired since 2021-06-30.
Follow-up to #5979. Removes the old, i.e. 22245C81E3BAEB4138B36061310F561200F4AD77, apt key from the Ansible install-time logic. The key has been expired since 2021-06-30.
Status
Ready for review.
Description of Changes
Towards #5923 .
Removes the key with fingerprint
22245C81E3BAEB4138B36061310F561200F4AD77
from the keyting installed by thesecuredrop-keyring
package.Testing
securedrop-keyring
keyring, with fingerprint2359E6538C0613E652955E6C188EDD3B7B22E6A3
make testinfra
passes against a staging environment built from this branch.Deployment
apt
operations will work, the keyring package will be updated successfully, and other packages should also be fine regardless of installation order.Checklist
If you added or removed a file deployed with the application:
If you made non-trivial code changes:
Choose one of the following: