SecureDrop 1.8.1-rc1 - version bump and cherry-picked changes. #5890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
requested review from
conorsch,
emkll,
kushaldas and
redshiftzero
as code owners
emkll
changed the title
emkll
previously approved these changes
Apr 7, 2021
There was a problem hiding this comment.
changes look good to me, thanks @zenmonkeykstop . deb tests are failing due to builder image needing updates, we will do that on release day.
This is going to need a final rebase to resolve conflicts here (due to changes in release/1.8.1)
(cherry picked from commit a24e2bc)
On Ubuntu Focal installed from ISO, the "mokutil" package wasn't installed by default. Let's add it early in the prepare-servers role, so we can use it to check for SecureBoot status before proceeding with installation. (cherry picked from commit 9ec39d8)
(cherry picked from commit 0441a1d)
(cherry picked from commit 94e3f98)
Adds a new rules group and also the related decoder. (cherry picked from commit d289c1a)
(cherry picked from commit 19ade45)
zenmonkeykstop
force-pushed
the
cherrypicked-1.8.1-rc1
branch
from
249cc7b to
d4b0b43
Compare
- pylint 2.5.0 -> 2.7.0 (python 3.6+ required, no review as dev only) - pyyaml 5.3.1 -> 5.4.1 (python 3.6+ required, previously reviewed) (cherry picked from commit 053463e)
(cherry picked from commit 938a042)
Required in order to maintain support for Python 3.5, under Xenial. The python-dateutil package pulls in whatever the latest setuptools-scm version is, and as of setuptools_scm>=6, Python 3.5 is no longer supported. (cherry picked from commit dcee956)
We have to install the correct version of setuptools_scm in the virtualenv created by the `dh-virtualenv` tool. This is managed by: https://github.com/spotify/dh-virtualenv/blob/0.11/dh_virtualenv/deployment.py#L145-L146 Only problem is that `pip` does not support hash verification when used via command line. (cherry picked from commit 68e7e9c)
emkll
force-pushed
the
cherrypicked-1.8.1-rc1
branch
from
d4b0b43 to
4bdccbf
Compare
emkll
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Squashed changelog edits into a single commit, with no changes to the diff:
https://github.com/freedomofpress/securedrop/compare/d4b0b43..4bdccbf
Should be good to merge when CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Towards #5891
Initial RC for SecureDrop 1.8.1
Testing
release/1.8.1is identical torelease/1.8.0