Correct backup location of custom logo #5880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zenmonkeykstop
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Ran through test plan, worked as expected. Also restored with:
- an old backup with
logo.pngbut notcustom-logo.png- the custom logo on the server stayed active ✔️ - a new backup with
custom_logo.pngafter removing it server-side - the custom logo was updated from the backup ✔️
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Testing
./securedrop-admin --force backupfrom~/Persistent/securedropcustom_logo.png(under/var/www)/var/www/securedrop/static/i/custom_logo.pngon app)Deployment
No special considerations; instructions added via freedomofpress/securedrop-docs#181 can be removed once this is included in a release.
Checklist