Added -u flag to tmux invocations, to force the use of UTF-8 for CLI QR codes #5844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5841
Adds the
-u
flag to tmux invocations in/etc/profile.d/securedrop_additions.sh
- this is required for qr codes to render properly frommanage.py
.Testing
on a production (1.8.0-rc1 currently) Focal system:
ssh app
in an Admin Workstationwww-data
user, in/var/www/securedrop
, run./manage.py add-admin
and confirm that the qr code is rendered as a black square.~/Persistent/securedrop/install_files/securedrop-config-focal/etc/profile.d/securedrop_additions.sh
to the application server/etc/profile.d/securedrop_additions.sh
with the file you just copied, preserving the originals permissions and ownershipssh app
www-data
user, in/var/www/securedrop
, run./manage.py add-admin
and confirm that the qr code is rendered correctly.Deployment
This is deployed in the securedrop-config package, and should be focal-only.
Checklist
If you made non-trivial code changes: