Use paxctl for Xenial, paxctld for Focal #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
no-paxctl-for-focal
branch
2 times, most recently
from
ae46ad9 to
a308769
Compare
Continues to use paxctld under Xenial, same as always, but removes any use of it under Focal, where paxctld is already preferred. Updated the tests accordingly. Removes an unused (xfail) paxctl test, since it wasn't running anyway. Preserved the "paxctld" dependency for securedrop-app-code, since the postinst logic still uses it. We can remove that after OS migration. Removes mention of the 4.14.x kernel series for Focal, as well, since we don't plan to support that series post-Xenial.
conorsch
force-pushed
the
no-paxctl-for-focal
branch
from
a308769 to
4cf8cc8
Compare
kushaldas
approved these changes
Feb 23, 2021
| @@ -44,4 +44,4 @@ securedrop_pkg_grsec_xenial: | |||
|
|
|||
| securedrop_pkg_grsec_focal: | |||
| ver: "5.4.97" | |||
| depends: "linux-image-5.4.97-grsec-securedrop,linux-image-4.14.188-grsec-securedrop,intel-microcode" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Closes #3916.
Continues to use paxctld under Xenial, same as always, but removes any
use of it under Focal, where paxctld is already preferred.
Updated the tests accordingly. Removes an unused (xfail) paxctl test,
since it wasn't running anyway. Preserved the "paxctld" dependency for
securedrop-app-code, since the postinst logic still uses it. We can
remove that after OS migration.
Removes mention of the 4.14.x kernel series for Focal, as well, since we
don't plan to support that series post-Xenial.
Testing
Deployment
Changes are Focal-specific, Xenial behavior has been preserved.
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you added or removed a file deployed with the application:
If you made non-trivial code changes:
Choose one of the following:
If you added or updated a code dependency:
Choose one of the following: