Installs release-upgrader in prepare-servers role #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
commented
Feb 16, 2021
| - name: Install python and packages required by installer | ||
| raw: apt install -y python apt-transport-https dnsutils | ||
| register: _apt_install_prereqs_results | ||
| changed_when: "'0 upgraded, 0 newly installed, 0 to remove' not in _apt_install_prereqs_results.stdout" |
There was a problem hiding this comment.
I revised the order of these tasks, because we must ensure that python3 is present before using an Ansible module. That's why the previous tasks are using raw, because we aren't sure yet.
Closes #5781. Adds the package to an early run, mostly to satisfy dev/testing environments where deb packages are installed directly as part of test runs. Also updates the "python" -> "python3" in the same task, since on Focal the former would result in (EOL'd) python2 being unnecessarily installed. Updated tests to match.
conorsch
force-pushed
the
5781-release-upgrader-settings
branch
from
5a43431 to
4248549
Compare
|
@kushaldas has committed to reviewing this change. |
kushaldas
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Closes #5781. Adds the package to an early run, mostly
to satisfy dev/testing environments where deb packages are installed
directly as part of test runs.
Also updates the "python" -> "python3" in the same task, since on Focal
the former would result in (EOL'd) python2 being unnecessarily installed.
Updated tests to match.
Testing
Make sure you use the newest Vagrant boxes available, preferably libvirt. At least
202102.02.0should exhibit the problem.Run
make staging. Observe it passes.Optionally we can update the boxes used in CI, which would shave a few minutes off each staging-with-rebase run, but not doing that now since the motivation here is to unbreak dev environments.
Deployment
None, we expect this package to be installed on hardware, and it indeed always have been. Dev-focused.