Update builder image and fix CI target for bandit #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builder image needed updates
The sid package was introducing broken dependencies.
Image needed updates
emkll
force-pushed
the
update-builder-20210126
branch
from
1b4eba0 to
355cee0
Compare
conorsch
reviewed
Jan 26, 2021
| @@ -296,13 +296,13 @@ jobs: | |||
| name: Check Python dependencies for CVEs | |||
| command: | | |||
| fromtag=$(docker images |grep securedrop-test-xenial-py3 |head -n1 |awk '{print $2}') | |||
| DOCKER_BUILD_ARGUMENTS="--cache-from securedrop-test-xenial-py3:${fromtag:-latest}" securedrop/bin/dev-shell bash -c "sudo pip3 install -q --upgrade safety && make -C .. safety" | |||
| DOCKER_BUILD_ARGUMENTS="--cache-from securedrop-test-xenial-py3:${fromtag:-latest}" securedrop/bin/dev-shell bash -c "pip3 install -U -q --upgrade safety && make -C .. safety" | |||
There was a problem hiding this comment.
-U is redundant with --upgrade already in the task list. Seems like it's lack of sudo privileges that would have resolved #5748. Not a blocker, since today is release day and CI runs take a long time, just pointing it out in case I'm missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5748
Fixes #5747
Towards #5689
Changes proposed in this pull request:
Testing
Deployment
Dev-only