Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
The 322 test was not yet deprecated in our last pinned version (1.4.0) so removing it from the skip list in #5670 broke in local environments in which bandit wasn't upgraded (as is done each run in CI).
Also, 1.4.0 didn't yet support glob patterns in bandit's
--exclude
option, so running it locally would take forever as the.venv
directory was scanned.Testing
Verify current problems
rm -rf .venv && make venv && . .venv/bin/activate
make bandit
: It should take forever and complain about test 322.Verify fix
git checkout -b upgrade-bandit origin/upgrade-bandit
rm -rf .venv && make venv && . .venv/bin/activate
make bandit
: It should only check 76 files, finish quickly, and not complain about test 322.Deployment
dev only.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made non-trivial code changes:
Choose one of the following: