Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libvirt-share target #5587

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Remove libvirt-share target #5587

merged 1 commit into from
Oct 19, 2020

Conversation

eloquence
Copy link
Member

Status

Ready for review

Description of Changes

Removed Makefile target libvirt-share used for mounting host folder in a Tails VM. We're not using it in practice and are removing it from the docs (freedomofpress/securedrop-docs#33). Marking as draft until docs PR is merged, but can be reviewed/approved in draft state.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visual review, will merge once flipped from draft.

@eloquence eloquence marked this pull request as ready for review October 19, 2020 16:09
@zenmonkeykstop zenmonkeykstop merged commit 1728f5c into develop Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants