Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout on OSSEC fetch tasks #5542

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

conorsch
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #5540

Affects the build logic. We saw CI failures related to the timeout being
reached. Default timeout is only 10s, so let's bump that up to 30s in an
attempt to make the build process more durable.

Testing

Is CI passing? If so, visual review is sufficient.

Deployment

Only affects build/CI environments, no direct implications for prod deploys.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

Affects the build logic. We saw CI failures related to the timeout being
reached. Default timeout is only 10s, so let's bump that up to 30s in an
attempt to make the build process more durable.
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual review, should be good to merge when CI passes

@zenmonkeykstop zenmonkeykstop merged commit f81e415 into develop Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deb-tests-focal CI job flakes with connection failure
3 participants