Further redaction of wordlist #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main objective is to avoid combinations of words that could be offensive or distracting.
eloquence
force-pushed
the
4225-redact-wordlists
branch
from
4dc5415 to
89eb3af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective is to avoid combinations of words that could be offensive or distracting. Nouns that are inoffensive by themselves may become offensive in certain combinations.
The goal is not to entirely avoid humorous or mildly offensive combinations (that seems impossible given the size of the word list), so the mental test I applied is "could this be distracting if said out loud (in combination with other words)" or "is this inherently offensive of potentially offensive in combination". My sense is that this is an iterative process, and we should do at least one more pass before closing out #4225.
Status
Ready for review
Description of Changes
Towards #4225
Testing
Inspect diff for overzealous removal or other words that should be removed
Deployment
Should only impact newly generated sources, so no expected deployment impact