Update syntax for type annotations #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushaldas
suggested changes
Jun 1, 2020
securedrop/rm.py
Outdated
| @@ -22,8 +22,7 @@ | |||
| import subprocess | |||
|
|
|||
|
|
|||
| def shred(path, delete=True): | |||
| # type: (str, bool) -> None | |||
| def shred(path: str, delete: bool=True) -> None: | |||
There was a problem hiding this comment.
This should be
def shred(path: str, delete: bool = True) -> None:
pierwill
force-pushed
the
pierwill-type-syntax-1
branch
from
774a619 to
310a8ba
Compare
|
Thanks! Force-pushed that change— |
|
We will have to rebase after #5286 is merged. |
pierwill
force-pushed
the
pierwill-type-syntax-1
branch
from
310a8ba to
569851a
Compare
|
This likely just needs one more rebase, because of the Tor browser update. |
Use PEP484 syntax in ./securedrop/rm.py
pierwill
force-pushed
the
pierwill-type-syntax-1
branch
from
569851a to
4f8abad
Compare
|
Rebased and force pushed— |
|
@pierwill let CI get done, I will re-review formally and merge. Thank you once again :) |
kushaldas
approved these changes
Jun 3, 2020
This was referenced Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Use PEP484 syntax in ./securedrop/rm.py.
Work toward #5282.
Testing
make typelintexits zero