Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed submission preference alert from top of config page #5223

Merged
merged 1 commit into from
May 4, 2020

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review / Work in progress

Description of Changes

Fixes #5220

Adds document submission flash message to the list of messages not displayed at the top of pages, similarly to the handling for the logo form on the instance config page. (It was being displayed unstyled due to the message category not having a corresponding css style)

Testing

  • checkout this branch and run make dev
  • log into the journalist interface using the test credentials, and navigate to the config section: /admin/config
  • change the submissions preference at the bottom of the page
  • the config page is re-rendered without a flash message at the top of the page, and with the "Preferences saved" message rendered correctly in the Submissions Preferences section.

Deployment

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

@zenmonkeykstop zenmonkeykstop added this to the 1.3.0 milestone May 4, 2020
@rmol
Copy link
Contributor

rmol commented May 4, 2020

I thought we were going to make it only appear at the top of the page?

@zenmonkeykstop
Copy link
Contributor Author

@rmol IMO there's a good case for some UX attention on the admin interface in general, including alert placement. But for now this is just a bug fix to restore the intent of the original PR.

Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sounds good, looks good, works good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance configuration flash message is unstyled
2 participants