Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.0] Backport 5216 message #5217

Merged
merged 1 commit into from
May 4, 2020
Merged

[1.3.0] Backport 5216 message #5217

merged 1 commit into from
May 4, 2020

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented May 1, 2020

Status

Ready for review

Description of Changes

Backports #5216

Testing

Does the PR contain the same commits as #5216 ?

@zenmonkeykstop zenmonkeykstop changed the base branch from develop to release/1.3.0 May 1, 2020 15:05
@zenmonkeykstop zenmonkeykstop changed the title Backport 5216 message [1.3.0] Backport 5216 message May 1, 2020
@zenmonkeykstop zenmonkeykstop added this to the 1.3.0 milestone May 1, 2020
@emkll
Copy link
Contributor

emkll commented May 4, 2020

This will need to be rebased on latest release/1.3.0 after merging ci fix in #5222

@zenmonkeykstop
Copy link
Contributor Author

Rebased and ready for review.

The "show codename" tool is now above the message flashed when a
logged-in source logs in again, not below.

(cherry picked from commit b5ab5ca)
@zenmonkeykstop zenmonkeykstop force-pushed the backport-5216-message branch from c9a99e7 to 0be4426 Compare May 4, 2020 14:58
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zenmonkeykstop, good to merge when CI passes.

@emkll emkll merged commit 19cbeed into release/1.3.0 May 4, 2020
@emkll emkll deleted the backport-5216-message branch May 4, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants