Use cron-apt instead of apt upgrade molecule upgrade testing scenario

[emkll]

Status

Work in progress

The challenge here will be mostly to deal with packages on the apt server that are not tracked locally: the kernel images, tor packages, and now ossec dependencies.

For these reasons, introduced a commit to append apt-test.freedom.press to security.list prior to running cron-apt, to ensure kernel images referred to my the metapackage are pulled in during the upgrade.

Feedback is welcome, as I am not sure this is the best approach (though it seems like an easy/quick fix that will help prevent future regressions when it comes to apt dependencies).

Description of Changes

Fixes #4659

Changes proposed in this pull request:

Testing

Local packages

• make upgrade-start
• make upgrade-test-local completes successfully

Apt-test packages

• make upgrade-qa-start
• make upgrade-test-qa

Deployment

Test only

Checklist

If you made non-trivial code changes:

• I have written a test plan and validated it for this PR

[kushaldas]

I am testing this one.

[kushaldas]

@emkll make upgrade-test-local command fails with the following error:

    
    TASK [app-test : Install gettext] **********************************************
    fatal: [app-staging]: FAILED! => {"cache_update_time": 1588683907, "cache_updated": false, "changed": false, "msg": "'/usr/bin/apt-get -y -o \"Dpkg::Options::=--force-confdef\" -o \"Dpkg::Options::=--force-confold\"     install 'gettext'' failed: E: Unable to correct problems, you have held broken packages.\n", "rc": 100, "stderr": "E: Unable to correct problems, you have held broken packages.\n", "stderr_lines": ["E: Unable to correct problems, you have held broken packages."], "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\nSome packages could not be installed. This may mean that you have\nrequested an impossible situation or if you are using the unstable\ndistribution that some required packages have not yet been created\nor been moved out of Incoming.\nThe following information may help to resolve the situation:\n\nThe following packages have unmet dependencies:\n gettext : Depends: libcroco3 (>= 0.6.2) but it is not installable\n           Depends: libunistring0 but it is not installable\n           Recommends: libasprintf-dev but it is not going to be installed\n           Recommends: libgettextpo-dev but it is not going to be installed\n", "stdout_lines": ["Reading package lists...", "Building dependency tree...", "Reading state information...", "Some packages could not be installed. This may mean that you have", "requested an impossible situation or if you are using the unstable", "distribution that some required packages have not yet been created", "or been moved out of Incoming.", "The following information may help to resolve the situation:", "", "The following packages have unmet dependencies:", " gettext : Depends: libcroco3 (>= 0.6.2) but it is not installable", "           Depends: libunistring0 but it is not installable", "           Recommends: libasprintf-dev but it is not going to be installed", "           Recommends: libgettextpo-dev but it is not going to be installed"]}

[eloquence]

@kushaldas has made a commitment to do continued (4 hour) time-boxed worked on this PR, w/ goal to resolve above issue & others encountered in testing, as part of 5/6-5/20 sprint.

[eloquence]

Deferring from the 5/20-6/3 sprint in favor of another improvement we're hoping to land to ease QA burden, #4216.

[emkll]

Closing as we are considering unattended-upgrades as we migrate to Focal #5295