Remove MAT #519
Remove MAT #519
Conversation
This reverts commit 6735ffa, reversing changes made to c59609d. Conflicts: .travis.yml install_files/source-requirements.txt securedrop/requirements/source-requirements.txt securedrop/source.py securedrop/source_templates/lookup.html securedrop/static/css/securedrop.css securedrop/store.py securedrop/tests/test_unit.py setup_dev.sh
|
Also need to remove python-poppler from setup_dev.sh and the Debian package. I can do this before merging. |
| hachoir-core==1.3.3 | ||
| hachoir-parser==1.3.4 | ||
| mutagen==1.22 | ||
| pdfrw==0.1 |
|
Also need to remove test_images/clean.jpg |
|
And remove line from the changelog |
This is needed for test_submit_clean_file. Not strictly necessary anymore now that we don't test submitting a dirty file to be scrubbed, but it doesn't hurt to have an extra test for submitting an image file. |
|
OMG getting rid of MAT brought back Flask's awesome debug logging! I've been trying to figure that one out for so long. Fixes #348. |
|
@diracdeltas @garrettr Sorry, it brought so much pain for you guys :( . I was going to suggest the removal of MAT, and move on to other solution. MAT seems to not be maintained that well anymore. I might be wrong. What solution will you use to scrape Metadata for now? |
|
Oh no worries I found the conservation. #497 |
@gnusosa Thanks for all your work! It's too bad we can't include this in the 0.3 release. If you're interested in doing more work with metadata analysis, I think we're going to start building a tool to help journalists analyze and sanitize metadata after 0.3 is released. |
|
@garrettr Yeah, I would love to work on that. Let me know if you have issues or any spec on this. |
|
I created #543 for this new tool. |
Fix #497
Close #492
Fix #348
Apologize to @gnusosa